Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Updated packaging for multiple connectors #220

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Updated packaging for multiple connectors #220

merged 5 commits into from
Nov 3, 2022

Conversation

planetf1
Copy link
Member

@planetf1 planetf1 commented Oct 21, 2022

This change proposes improvements to build packaging as per odpi/egeria-connector-jdbc#13

  • Refactored top level gradle file, similar to changes I've recently made to egeria - hopefully simpler/clearer
  • Dependency constraints are primarily via an import of the egeria BOM
  • docker build removed -- our charts support dynamic loading of connector jars. No longer needed/adds complexity
  • updates org.odpi* dependencies to 'compileOnly' -- since they are already within the egeria platform, prevents them getting included in any uber jars we might have in future (technically slf4* qualifies too, but I left this for clarity?)
  • Artifact published by build action updated with new name (as it's a combination of all 3 connectors)
  • Added a few validators to ensure dependencies are in sync, and no clashes on capabilities
  • removes aggregate javadocs (not used)
  • deleted rogue text file

Tested

  • ./gradlew build -> builds as usual
  • ./gradlew ./gradlew PublishToMavenLocal -> creates local maven artifacts

I can't fully test the ci/cd publishing of snapshots until this is merged -- and may then need a few iterations.

I suggest this for review -- and if ok I will then check the end-end snapshot publishing & update

@planetf1
Copy link
Member Author

@dwolfson -- here's a first pass at the approach to fix up the build process fully for our multiple connectors
@lcpopa -- hoping this doesn't break anything .... I've not tested the runtime

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 21, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

@planetf1 planetf1 enabled auto-merge November 3, 2022 09:49
@planetf1 planetf1 merged commit 96c3cd5 into odpi:main Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant