Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master readonly less readonly lul #5118

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Master readonly less readonly lul #5118

wants to merge 3 commits into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Oct 22, 2024

Pull request status dashboard

@LucasLefevre LucasLefevre force-pushed the master-readonly-less-readonly-lul branch 2 times, most recently from 4729457 to 9a6f212 Compare October 22, 2024 13:51
@LucasLefevre LucasLefevre force-pushed the master-readonly-less-readonly-lul branch from 9a6f212 to 757c165 Compare October 24, 2024 07:44
rrahir
rrahir reviewed Nov 19, 2024
View reviewed changes
src/types/commands.ts
@@ -168,6 +168,9 @@ export const readonlyAllowedCommands = new Set<CommandTypes>([
"START",
"ACTIVATE_SHEET",

// allow to check checkboxes, select dropdowns, use filters
"UPDATE_CELL",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird - we'd rely on the fact that this will not be propagated on the network?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... if you have better/more robust idea...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrahir rrahir rrahir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasLefevre @robodoo @rrahir