Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"underscore" as seperator for file names #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sahnreis
Copy link

Description

Fixes issue #129
Switched from spaces as file name seperator to "_" (underscore) and updated .gitignore to include the new file names.

Type of change

Put an X in the relevant boxes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please generally describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Did multiple exports and checked file names afterwards to verfiy.

Test Configuration:

  • OS: Win 10
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have adequately commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings (if there are any, note them and why they could not have been removed)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Sahnreis
Copy link
Author

hey @odedshimon
have you found some time to have a look at the pr?

@odedshimon
Copy link
Owner

@Sahnreis Hey,
Thank you for opening this PR.
Normally I respond fater, sorry for that.
I'm currently abroad and therfore didn't have the time to look at it so far.
I will be back by the end of April and will check that for sure shortly after!

Copy link
Owner

@odedshimon odedshimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see notes, I will merge after adjustments

@@ -351,3 +351,8 @@ MigrationBackup/

# Ignore Visual Studio launchSettings (e.g application arguments)
**/Properties/launchSettings.json

# Ignore exported files
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for that

@@ -1,8 +1,6 @@
using System;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for those deletions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants