Update python, node, remove headless images #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgerigmeyer
commented
Nov 18, 2024
.github/workflows/build.yml
Outdated
| suffix: ['', '-headless'] | ||
| python: ['3.12', '3.11', '3.10', '3.9'] | ||
| node: ['20', '18', '16'] | ||
| python: ['3.13', '3.12', '3.11', '3.10'] |
There was a problem hiding this comment.
If you want, it looks like we could remove 3.10 here too: https://github.com/search?q=org:oddbird+ghcr.io/oddbird/pyjs:py3.10&type=code
There was a problem hiding this comment.
I went ahead and removed node 18 as well, it looks like we are on 16 or 20 on all projects
|
@jgerigmeyer do we also want to use corepack in these base images instead of enabling it on each project? |
|
@jerivas Looks good to me! |
jerivas
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.