Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add swiftmailer submodule #8

Closed
wants to merge 1 commit into from
Closed

add swiftmailer submodule #8

wants to merge 1 commit into from

Conversation

dsavchenko
Copy link
Member

fix #7

@volodymyrss
Copy link
Member

volodymyrss commented Nov 19, 2021

It's included in the container: https://github.com/oda-hub/frontend-container/blob/master/Dockerfile#L91

Since it's not our own ongoing development, I do not think it's best to add it as a submodule.

edit: and the library is here added https://github.com/oda-hub/frontend-container/blob/master/Dockerfile#L98 in vendor/swiftmailer/swiftmailer

@volodymyrss volodymyrss added the question Further information is requested label Nov 19, 2021
@burnout87
Copy link

It's included in the container: https://github.com/oda-hub/frontend-container/blob/master/Dockerfile#L91

this is the reason why I also see this error in my local instance, not very critical, but it's good top be certain that this is the exaplanation

@volodymyrss
Copy link
Member

It's included in the container: https://github.com/oda-hub/frontend-container/blob/master/Dockerfile#L91

this is the reason why I also see this error in my local instance, not very critical, but it's good top be certain that this is the exaplanation

you swiftmailer is the reason? quite likely! Library location should be set differently, where composer installs it - in vendor...

@dsavchenko
Copy link
Member Author

With the current Dockerfile it causes the issue, and a quick way to fix was to add it as a submodule.
But I agree, if it could be managed without adding a submodule, it should.

@volodymyrss
Copy link
Member

With the current Dockerfile it causes the issue, and a quick way to fix was to add it as a submodule. But I agree, if it could be managed without adding a submodule, it should.

It is an issue because the DB does not have the record where to find it. I'd really best make the change to https://github.com/oda-hub/frontend-drupal7-db-for-astrooda . The module is already there, but not enabled by default.

image

@volodymyrss
Copy link
Member

volodymyrss commented Nov 19, 2021

We already anticipated it in here oda-hub/frontend-chart#14. We can discuss if it should be done soon. In principle, mail config is site-specific. But swiftmailer probably should be the defalt.

https://github.com/oda-hub/meetings/blob/main/2021-11-22/agenda.md

@volodymyrss
Copy link
Member

decided to do it soon in oda-hub/frontend-chart#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swiftmailer library is not actually included in the repo
3 participants