feat: signSync, verifySync
#211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
changed the title
|
Implemented now in a way, that it does not break. EDIT: |
4 tasks
wolfy1339
added
Type: Breaking change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gr2m
reviewed
Dec 2, 2023
|
@gr2m |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gr2m
changed the title
signSync, verifySync
gr2m
requested changes
Dec 4, 2023
There was a problem hiding this comment.
actually, can you document signSync and verifySync?
I'm not 100% sure if we really need it, I don't like the fact that available methods diverge between the JS runtimes.
Maybe let's leave out the introduction of signSync and verifySync and discuss that in a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We anyway just check if sha256 is given.
Add the signSync and verifySync methods, as crypto code runs in C++ code of node, which makes it by nature block the event loop of node. By making it sync we reduce the unecessary overhead of creating intermediary Promises, which are thrown away anyway. So we can use that in probot / webhooks.js.
Only when using web crypto async maybe makes sense, because that runs by nature async, but I suspect to be signifcantly slower.
We need to patch then webhooks.js repo to use sync calls.
@semver-minor.
Resolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!