Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: Adds update to the build workflow #54

Merged
merged 9 commits into from
Mar 29, 2024
Merged

maint: Adds update to the build workflow #54

merged 9 commits into from
Mar 29, 2024

Conversation

nickfloyd
Copy link
Collaborator

@nickfloyd nickfloyd commented Mar 28, 2024 •
edited
Loading

Adds the middleware approach using a combination of this tool and the kiota info API.

@nickfloyd nickfloyd marked this pull request as ready for review March 28, 2024 20:12
@nickfloyd nickfloyd requested a review from kfcampbell March 28, 2024 20:12
@nickfloyd nickfloyd marked this pull request as draft March 28, 2024 20:16
@nickfloyd nickfloyd marked this pull request as ready for review March 29, 2024 17:48
kfcampbell
kfcampbell approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't think the (AI prompt?) comments are necessary but this is a big improvement over simply hard-coding the dependencies on the C# side like we had before.

post-processors/csharp/main.go Outdated Show resolved Hide resolved
post-processors/csharp/main.go Outdated Show resolved Hide resolved
post-processors/csharp/main.go Outdated Show resolved Hide resolved
@nickfloyd nickfloyd changed the title Adds update to the build workflow maint: Adds update to the build workflow Mar 29, 2024
@nickfloyd nickfloyd merged commit 18f7c63 into main Mar 29, 2024
5 checks passed
@nickfloyd nickfloyd deleted the auto-update-dotnet branch March 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickfloyd @kfcampbell