feat: Adds a prototype for token based auth #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a quick take on implementing a token auth provider. Other providers will need to be implemented. It does 3 fundamental things to help the generated SDK call the API
HttpClientRequestAdapter
.Why
The provider pattern a standard approach to providing extended functionality for things like this, it is also what is recommended by our Kiota friends.
Implementation details
GITHUB_TOKEN
WebhookConfig.cs
post generation where the using statementusing Microsoft.Kiota.Abstractions;
should be qualified withusing Microsoft.Kiota.Abstractions.Serialization;
- we need a middleware for this and to investigate why this is happening with that model only.cc: @baywet | if you have time look just for a gut check on if we're headed the right direction.