Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @octokit/tsconfig to v4 #635

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 24, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/tsconfig ^3.0.0 -> ^4.0.0 age adoption passing confidence

Release Notes

octokit/tsconfig (@​octokit/tsconfig)

v4.0.0

Compare Source

Features
BREAKING CHANGES
  • Required, but potentially undefined does not have the same intent as optional. This
    rule will enforce us to be explicit in our type declarations and how we expect octokit APIs should
    be used.

v3.1.0

Compare Source

Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 24, 2024
@oscard0m oscard0m requested a review from wolfy1339 September 24, 2024 18:24
oscard0m
oscard0m previously approved these changes Sep 24, 2024
Copy link
Contributor Author

renovate bot commented Sep 27, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

wolfy1339
wolfy1339 previously approved these changes Sep 27, 2024
@wolfy1339
Copy link
Member

It seems we have uncovered some type errors unrelated to this upgrade

@wolfy1339 wolfy1339 dismissed their stale review September 27, 2024 14:11

type errrors

@wolfy1339
Copy link
Member

I found the cause of the issue, we are wrongfully casting to AsyncIterableIterator<any> when it should instead be AsyncIterator<any> as the iter() function returns an object with one of the keys as Symbol.asyncIterator which returns an object with a next() function.

Seems like this was an issue for a long time.

I don't expect there to be any changes to the published types, simply house-keeping

@wolfy1339 wolfy1339 force-pushed the renovate/major-octokit-monorepo branch from 6b809a7 to c87392c Compare September 27, 2024 21:54
@wolfy1339
Copy link
Member

I split out the changes into their own PR #637

@wolfy1339 wolfy1339 added the Status: Blocked Some technical or requirement is blocking the issue label Sep 27, 2024
@wolfy1339 wolfy1339 merged commit c3c5dbc into main Sep 29, 2024
8 checks passed
@wolfy1339 wolfy1339 deleted the renovate/major-octokit-monorepo branch September 29, 2024 22:18
Copy link
Contributor

🎉 This PR is included in version 11.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Status: Blocked Some technical or requirement is blocking the issue Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants