Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: correct mkdirp import, fix full relative import in tests, fix prettier usage #614

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER


Before the change?

  • The tests would fail because the import for mkdirp wasn't the right one

After the change?

  • The import for mkdirp is updated and tests run

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Oct 24, 2023
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title fix: correct mkdirp import, fix full relative import in tests fix: correct mkdirp import, fix full relative import in tests, fix prettier usage Oct 24, 2023
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@gr2m gr2m changed the title fix: correct mkdirp import, fix full relative import in tests, fix prettier usage build: correct mkdirp import, fix full relative import in tests, fix prettier usage Oct 25, 2023
@gr2m gr2m merged commit c5d8733 into main Oct 25, 2023
@gr2m gr2m deleted the fix-update-workflow branch October 25, 2023 16:11
Copy link
Contributor

🎉 This PR is included in version 22.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants