(fix) Use Unauthorized access message #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forbidden 403
yahyayouness
commented
Nov 23, 2022
| @@ -10,7 +10,7 @@ const API_KEY = '395a9cce-6ffc-48b8-8372-b95089c3abc6' | |||
| app.get('/formations', (req, res) => { | |||
| const apiKeyFromHeader = req.headers['x-api-key'] | |||
| if (API_KEY !== apiKeyFromHeader) { | |||
| res.status(401).send({code: 401, error: 'FORBIDDEN'}) | |||
| res.status(401).send({code: 401, error: 'Unauthorized: Access denied due to invalid subscription key. Make sure to provide a valid key for an active subscription'}) | |||
There was a problem hiding this comment.
(suggestion) On peut utiliser la spec https://jsonapi.org/format/#errors pour l'objet error et rappeler l'importance qu'il soit standard pour une meilleure gestion d'erreur coté client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
Wrong message for 401.
Solution:
Use Unautorized access message instead if 403 forbidden message