Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dockerfile and docker-compose to run Coup #72

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

ScribblerCoder
Copy link
Contributor

@ScribblerCoder ScribblerCoder commented Apr 1, 2024

feature requested in #68.

I made a multistage Dockerfile that creates a 151MB docker image. With that I also created a simple docker-compose.yml file to make it easier for people to run the application using docker compose up.

@octachrome I noticed that by default the application runs without a database. If needed I can add it to the docker-compose so that it spins up a couchDB container alongside with the main application.

I hope this project is still maintained

@ScribblerCoder ScribblerCoder changed the title add dockerfile and compose to run Coup add Dockerfile and docker-compose to run Coup Apr 1, 2024
@octachrome
Copy link
Owner

Sorry for slow response. This looks good. Can you please put the Docker stuff into its own directory to keep things tidy?

Copy link
Owner

@octachrome octachrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile seems overly complicated. I think it could be about half the size unless I am missing something.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ScribblerCoder
Copy link
Contributor Author

Sorry for slow response. This looks good. Can you please put the Docker stuff into its own directory to keep things tidy?

Done. I also updated README.md with run instructions

Copy link
Owner

@octachrome octachrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks useful

@octachrome octachrome merged commit 7216e86 into octachrome:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants