Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scriptType and defaultScriptType #296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gigitsu
Copy link

@Gigitsu Gigitsu commented Mar 16, 2016

By default, ocLazyLoad doesn't add type attribute to script element. This led to an error when loading js file with 'yield' using FireFox, specifically the error is 'SyntaxError: yield is a reserved identifier'.

To let FireFox correctly recognize the js file, I need to put type type="application/javascript;version=1.8" in script element.

Now you can set the default script type attribute by configuration with

angular.module('app', ['oc.lazyLoad']).config(['$ocLazyLoadProvider', function($ocLazyLoadProvider) {
  $ocLazyLoadProvider.config({
    defaultScriptType: 'application/javascript;version=1.8'
  });
}]);

or directly with your router

$routerProvider.when('/MyCtrl', {
  templateUrl: 'views/MyView.html',
  controller: 'MyCtrl',
  resolve: {
    lazy: ['$ocLazyLoad', function ($ocLazyLoad) {
      return $ocLazyLoad.load([{
        name: 'MyCtrl',
        files: ['scripts/controllers/MyCtrl.js'],
        scriptType: 'application/javascript;version=1.8'
      }]);
    }]
  }
})

@sukrosono
Copy link

why we need specify version here?

@Gigitsu
Copy link
Author

Gigitsu commented Mar 17, 2016

Because, otherwise, loading js files that uses 'yield' or 'let' keywords with FireFox leads to an error.

@kination
Copy link
Collaborator

Hello @Gigitsu, I couldn't find such error on FireFox though I used 'let' or 'yield' on example codes. Could you suggest simple example, or let me know your browser version?

@racabe
Copy link

racabe commented Dec 18, 2017

Hi, do you know when will be merge this change with the master branch? I need this change like minimum because some security auditories said that my code need to say the type "text/javascript" to javascript files. This is important for our team to pass the auditory completly.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants