Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: ADD our Git repo instead of downloading #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dockerfile: ADD our Git repo instead of downloading #111

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Contributor

No description provided.

@ochinchina
Copy link
Owner

the docker image will be auto-published by the circle-CI which must download the source code from github

@Al2Klimov
Copy link
Contributor Author

... but doesn't have to pull the source code from my changed local copy I'd like to test. In addition that saves a few MB on the wire.

@Al2Klimov
Copy link
Contributor Author

@ochinchina Maybe that CI even builds PRs like this one, but I'd like to test my changes offline (in a Docker container of mine) before even making a PR – this is my PR's rationale.

@ochinchina
Copy link
Owner

@Al2Klimov if you can move the changed Dockerfile to Dockerfile.local for your purpose? and then you can build the supervisor with the local source code instead of downloading from the github.

@Al2Klimov
Copy link
Contributor Author

I don't need even that – I just apply this patch temporarily.

I don't really need this PR in upstream – I just think it makes no sense to download something that's already present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @ochinchina