Skip to content

Commit

Permalink
Revert mock change and add fix for failing main test.
Browse files Browse the repository at this point in the history
  • Loading branch information
calina-c committed Oct 7, 2024
1 parent e380708 commit 748ebd6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ A "ppss" yaml file, like [`ppss.yaml`](ppss.yaml), holds parameters for all bots
When you run a bot from the CLI, you specify your PPSS YAML file.

pdr has basic stdout logging, but supports customisations.

To customise logging, copy and edit the existing `logging.yaml`:

```console
Expand Down
2 changes: 1 addition & 1 deletion pdr_backend/pdr_dashboard/callbacks/callbacks_home.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def update_predictoors_table_on_search(
]

if "show-favourite-addresses.value" in dash.callback_context.triggered_prop_ids:
if len(stored_predictoor_addrs) > 0:
if stored_predictoor_addrs and len(stored_predictoor_addrs) > 0:
selected_predictoors_addrs = stored_predictoor_addrs
else:
custom_predictoors = formatted_predictoors_data.filter(
Expand Down
2 changes: 1 addition & 1 deletion pdr_backend/pdr_dashboard/test/test_callbacks_home.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_favourite_addresses_search_input(
fav_addr_toggle.click()
time.sleep(2)
p_all, p_sel = _predictoor_count(dash_duo)
assert len(p_sel) == 1
assert len(p_sel) == 0


def test_checkbox_selection(_sample_app, dash_duo):
Expand Down

0 comments on commit 748ebd6

Please sign in to comment.