Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): reset.css should build to dist + CodeSandbox build error #855

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

dengfuping
Copy link
Collaborator

@dengfuping dengfuping commented Nov 21, 2024

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

  • None

💡 Background and solution

Before After
image image

image

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese - 🐞 修复打包后 dist 目录不包含 reset.css 样式文件的问题。- 🐞 修复 CodeSandbox 环境下编译报错、无法预览的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Nov 21, 2024

@dengfuping dengfuping changed the title fix(design): reset.css should build to dist fix(design): reset.css should build to dist + CodeSandbox build error Nov 21, 2024
@dengfuping dengfuping merged commit bc42f9b into master Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant