Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(style): Remove fixed barWidth for Bar and columnWidth for Column & TinyColumn & DualAxes #558

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

dengfuping
Copy link
Collaborator

@dengfuping dengfuping commented Apr 12, 2024

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

  • None

💡 Background and solution

Chart Before After
Bar image image
Column image image
TinyColumn image image
DualAxes image image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese - 💄 去掉 Bar 条形的固定宽度,改为自适应。- 💄 去掉 Column 和 DualAxes 柱形的固定宽度,改为自适应。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Apr 12, 2024

@dengfuping dengfuping changed the title improve(style): Remove fixed barWidth for Bar and columnWidth for Column & DualAxes improve(style): Remove fixed barWidth for Bar and columnWidth for Column & TinyColumn & DualAxes Apr 12, 2024
@dengfuping dengfuping merged commit 74cc206 into master Apr 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant