Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature input parameters support kv #386

Merged

Conversation

xiaodong-ji
Copy link
Contributor

@xiaodong-ji xiaodong-ji commented Aug 9, 2024

Summary

Optional parameter input_parameters supports input in kv format.
close #381

Solution Description

@Teingi
Copy link
Contributor

Teingi commented Aug 9, 2024

rca的结果文件不需要提交上来

@xiaodong-ji
Copy link
Contributor Author

rca的结果文件不需要提交上来

已经删掉了

core.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wayyoungboy wayyoungboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@xiaodong-ji
Copy link
Contributor Author

xiaodong-ji commented Aug 12, 2024

  1. 目前该 PR 支持 json 和 key-value 两种参数选项格式
0f218285b616e63b2683a90754b3d988
  1. json 参数格式错误时,使用 -v 参数会有提示
5627670cbaaea6c9f6f93e38b08641ed

@wayyoungboy wayyoungboy merged commit 9d8e7e2 into oceanbase:master Aug 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: obdiag rca run 的可选参input_parameters支持kv形式输入
3 participants