2.4.0 io update and support remote_client_sudo #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frf12
reviewed
Jul 30, 2024
stdio.py
Outdated
| self._before_critical = None | ||
| self._output_is_tty = False | ||
| self._input_is_tty = False | ||
| self.set_input_stream(input_stream) | ||
| self.set_output_stream(output_stream) | ||
| self.set_err_stream(error_stream) | ||
| # TODO print on doc | ||
| self.print_type = 0 # 0: use stdout, 1: use stdout and stderr, 2: just print result (json). when obdiag_version ≥ 3.0, print_type default 1 |
There was a problem hiding this comment.
如果要做type的话就搞个枚举吧
但这个逻辑我倾向于分开，这两将静默模式和是否使用stderr混在一个type里导致print_type的含义比较复杂。
而且是否使用stderr跟obdaig的版本和命令行选项有关，比较业务，这个放到stdio的type里相当于在一个通用的工具模块上理解的业务。
这块我倾向于在Stdio上提供silent_mode，如果业务上需要静默模式，就调用enable_silent_mode开启静默模式。
如果业务上需要使用stderr就传入sys.stderr，否则默认是error_stream=output_stream，或者__init__的默认值上还是保持error_stream=sys.stderr，但业务上如果没有使用stderr，就主动传入error_stream=sys.stdout
另外这个代码里没有看到just print result (json)这块能力
There was a problem hiding this comment.
io部分不再强耦合业务代码，改为通过inner_config在创建io的时候处理。
stdio.py
Outdated
| @@ -417,7 +437,7 @@ def __getstate__(self): | |||
| state = {} | |||
| for key in self.__dict__: | |||
| state[key] = self.__dict__[key] | |||
| for key in ['_trace_logger', 'input_stream', 'sync_obj', '_out_obj', '_cur_out_obj', '_before_critical']: | |||
| for key in ['_trace_logger', 'input_stream', 'sync_obj', '_out_obj', '_cur_out_obj', '_before_critical', '_cur_err_obj']: | |||
Teingi
reviewed
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.4.0 io update and support remote_client_sudo