Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittest for common/scene.py #371

Merged
merged 10 commits into from
Aug 7, 2024
Merged

unittest for common/scene.py #371

merged 10 commits into from
Aug 7, 2024

Conversation

YSevenK
Copy link
Contributor

@YSevenK YSevenK commented Jul 26, 2024

Summary

common/scene.py 文件添加测试 到 test/common/test_scene.py 目录下

Solution Description

使用通义灵码的单元测试功能进行开发
image

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

@Teingi
Copy link
Contributor

Teingi commented Jul 28, 2024

Add tianchi-competition-2024 label Now!

@Teingi
Copy link
Contributor

Teingi commented Aug 1, 2024

提交代码后需要确认是否报名成功了,步骤如下:
报名参赛步骤:报名——下载选手方案提交模版——提交结果
赛事报名官网:https://tianchi.aliyun.com/competition/entrance/532215/submission/1282​
image
表格内容要求:​
1. 选手需提供GitHub个人设置页面截图和通义灵码辅助编码使用截图(此项在提交模板里有参考截图示意。)​
2. 相关内容需要填写:
image
将​参赛表格​内容填写后,提交到【提交结果】中​
image
如有疑问可加入赛事交流群:钉钉群号:75530009710​

@YSevenK
Copy link
Contributor Author

YSevenK commented Aug 1, 2024 via email

@Teingi
Copy link
Contributor

Teingi commented Aug 5, 2024

建议:增加一下单测流水线,参考https://github.com/oceanbase/obdiag/blob/master/.github/workflows/test_sql_rule.yml

@YSevenK
Copy link
Contributor Author

YSevenK commented Aug 5, 2024

建议:增加一下单测流水线,参考https://github.com/oceanbase/obdiag/blob/master/.github/workflows/test_sql_rule.yml

好,我后面看一下

@Teingi
Copy link
Contributor

Teingi commented Aug 6, 2024

代码格式化的流水线没跑过,没有格式化代码。需要执行一下 black --check -S -l 256 . 参考文档:https://oceanbase.yuque.com/org-wiki-obtech-vh7w9r/imzr6c/dio3s4re84gz54pp

@YSevenK
Copy link
Contributor Author

YSevenK commented Aug 6, 2024

代码格式化的流水线没跑过,没有格式化代码。需要执行一下 black --check -S -l 256 . 参考文档:https://oceanbase.yuque.com/org-wiki-obtech-vh7w9r/imzr6c/dio3s4re84gz54pp

已完成

@Teingi
Copy link
Contributor

Teingi commented Aug 6, 2024

good job!

test/__init__.py Outdated
@time: 2022/6/20
@file: __init__.py
@desc:
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件删了吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

刚才试了一下,删除这个文件会报错

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边我帮你删了,后面的特性分支可以单独建一个分支去开发,尽量不要去在fork的仓库master分支上开发,因为master更适合在作为反合的目的分支进行处理,这样可以更好地获取源仓库里最新代码。
其他没什么问题了,祝获得好成绩~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,因为没有什么参与开源的经验,您提到的后面会注意,也祝您工作顺利 NO BUG!

@wayyoungboy wayyoungboy merged commit 91c0b6b into oceanbase:master Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants