obdiag实现参数、变量采集和比对功能 #329
Merged
obdiag实现参数、变量采集和比对功能 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � core.py � diag_cmd.py � handler/analyzer/analyze_parameter.py � handler/analyzer/analyze_variable.py � handler/gather/gather_parameters.py � handler/gather/gather_variables.py
Teingi
reviewed
Jul 15, 2024
handler/gather/gather_variables.py
Outdated
| @@ -76,8 +76,8 @@ def get_cluster_name(self): | |||
| cluster_info = self.obconn.execute_sql(sql) | |||
| cluster_name = cluster_info[0][0] | |||
| except Exception as e: | |||
| self.stdio.warn("failed to get oceanbase cluster name:{0}".format(e)) | |||
| self.stdio.verbose("get oceanbase cluster name {0}".format(cluster_name)) | |||
| self.stdio.warn("RCAHandler Failed to get oceanbase cluster name:{0}".format(e)) | |||
Teingi
reviewed
Jul 15, 2024
handler/gather/gather_parameters.py
Outdated
| @@ -87,8 +87,8 @@ def get_cluster_name(self): | |||
| cluster_info = self.obconn.execute_sql(sql) | |||
| cluster_name = cluster_info[0][0] | |||
| except Exception as e: | |||
| self.stdio.warn("failed to get oceanbase cluster name:{0}".format(e)) | |||
| self.stdio.verbose("get oceanbase cluster name {0}".format(cluster_name)) | |||
| self.stdio.warn("RCAHandler Failed to get oceanbase cluster name:{0}".format(e)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
实现功能如下：
1、参数和变量的采集功能
2、不同observer之间参数对比功能，找到不同的observer间值不同的参数
3、找出非默认值参数
4、找出和指定的变量采集对比后值发生变化的变量