javascript

[jiu33]

Summary

Solution Description

[CLAassistant]

All committers have signed the CLA.

[whhe]

Hi @jiu33, thanks for your contribution! I just updated the CI workflow configurations on master branch, could you please rebase on it and push your branch again? You also need to add a workflow yaml file javascript.yml like below:

name: JavaScript CI

on:
  push:
    paths:
      - '.github/workflows/javascript.yml'
      - 'javascript/**'
  pull_request:
    paths:
      - '.github/workflows/javascript.yml'
      - 'javascript/**'

jobs:
  ci:
    strategy:
      matrix:
        module:
          - name: 'mysql2'
            with_oceanbase_container: true
    uses: ./.github/workflows/basic-workflow.yml
    with:
      language: 'javascript'
      module: ${{ matrix.module.name }}
      with_oceanbase_container: ${{ matrix.module.with_oceanbase_container }}

[whhe]

Thanks for your contribution! I left some comments.

[whhe]

Typo: 'onst' -> 'const'

[whhe]

const

[whhe]

This should be in English right?

[jiu33]

sorry I do it

[whhe]

Hi @jiu33, can you translate the Chinese content in README.md to English? Mixing Chinese and English in one document may be confusing for users who only speak English.

[whhe]

LGTM