Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add a demo of Python sqlalchemy #57

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

521xueweihan
Copy link
Contributor

Summary

add sample for python sqlalchemy

  • example.py:A python script
  • demo:A minimal example project

Solution Description

@CLAassistant
Copy link

CLAassistant commented May 29, 2024

CLA assistant check
All committers have signed the CLA.

@521xueweihan 521xueweihan changed the title feat: add sample for sqlalchemy [Feat]: Add a demo of Python sqlalchemy May 29, 2024
Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left some comments.

python/sqlalchemy/README.md Outdated Show resolved Hide resolved
python/sqlalchemy/demo/db/base.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@521xueweihan 521xueweihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whhe rm author and fix port done.

@@ -33,6 +33,8 @@ jobs:
with_oceanbase_container: true
- name: 'mysql-connector-python'
language: 'python'
- name: 'sqlalchemy'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The with_oceanbase_container field of mysql-connector-python is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@whhe
Copy link
Member

whhe commented May 29, 2024

Looks like the CI job failed. Could you please add the missing field and fix it?

Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whhe whhe merged commit 3f8154c into oceanbase:master May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants