Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add a demo of SpringJDBC #44

Merged
merged 6 commits into from
May 20, 2024

Conversation

bruce-pang
Copy link
Contributor

Summary

This pull request introduces a new SpringJDBC OceanBase sample, aiming to enhance the documentation and examples available for developers integrating SpringJDBC with OceanBase.

Solution Description

  1. Setup and Configuration: A detailed setup configuration for integrating SpringJDBC with OceanBase, including Maven dependencies and application configuration files.
    2. Sample Application: A small application demonstrating the configuration and use of SpringJDBC to perform database operations.

@bruce-pang
Copy link
Contributor Author

@whhe SpringJDBC Demo has been re-developed, please review it.

@whhe
Copy link
Member

whhe commented May 20, 2024

Hi @bruce-pang, it seems that there is something wrong in the GitHub CI job of the newly added module, and maybe you should modify the configurations on database connection.

The ci workflow for pull requests created by new contributors currently needs to be triggered by an admin user, so you can't see the results of the ci job immediately. However, you can see job results in your forked repository https://github.com/bruce-pang/ob-samples/actions. Please try to fix the failure and make it pass, then we can merge it into the main branch.

@whhe whhe linked an issue May 20, 2024 that may be closed by this pull request
2 tasks
@bruce-pang
Copy link
Contributor Author

@whhe Done.

Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@whhe whhe merged commit 117e59f into oceanbase:master May 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat.]: Add a demo of SpringJDBC
2 participants