Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a demo of SpringBoot #10 #38

Closed
wants to merge 2 commits into from

Conversation

bruce-pang
Copy link
Contributor

Summary

close #10

Solution Description

README-CN.md

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@caifeizhi
Copy link
Contributor

Thanks for your contribution @bruce-pang . And, please add new modules in .github/workflows/ci.yml and we can merge it after the new ci job passes; just like :#36

@caifeizhi caifeizhi mentioned this pull request Apr 29, 2024
@whhe
Copy link
Member

whhe commented May 9, 2024

Thanks for you contribution.

I noticed that you added a new module with prefix oceanbase-, now we require that the name of the new module must be the same as the name of the component used, so please remove the directory prefix and so all modules will be named in the same style.

For the CI part, we require that the run.sh can actually be executed in GitHub Action of every one module, so you should configure the datasource in the sample with real connection info. Since we start a database instance by default in the basic ci, you can use the connection info of it, which is 'ip=localhost', 'port=2881', 'username=root@sys' or 'username=root@test' and 'password=' (empty).

@bruce-pang
Copy link
Contributor Author

@whhe Done.

@whhe
Copy link
Member

whhe commented May 14, 2024

@whhe Done.

I see you updated #40, but it introcudes 3 new modules. Can you separate these files into 3 pull requests?

Take this pull request for example, you can overwrite the files of current branch with the part of spring-boot-mysql-jpa in #40 and update this 'springboot' branch.

Besides, we take the component name as the module name, so here the new module directory should be spring-data-jpa. See the latest contribution guide at readme: English 中文

@bruce-pang
Copy link
Contributor Author

@whhe OK, I will split three new PRs and resubmit them, and close the original three PRs.

@bruce-pang bruce-pang closed this May 17, 2024
@bruce-pang bruce-pang deleted the springboot branch May 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat.]: Add a demo of SpringBoot
4 participants