Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add mybatis-plus samples #37

Merged
merged 11 commits into from
May 11, 2024
Merged

Conversation

VampireAchao
Copy link
Contributor

Summary

This pull request introduces a new MyBatis-Plus OceanBase sample, aiming to enhance the documentation and examples available for developers integrating MyBatis-Plus with OceanBase.

Solution Description

The solution includes the following key components:

  1. Setup and Configuration: A detailed setup configuration for integrating MyBatis-Plus with OceanBase, including Maven dependencies and application configuration files.
  2. Initialization Script: An updated init.sql script that not only creates necessary tables but also populates them with initial data for immediate testing and demonstration purposes.
  3. Sample Application: A small Spring Boot application demonstrating the configuration and use of MyBatis-Plus to perform database operations such as read on the OceanBase database.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@whhe whhe self-requested a review April 26, 2024 03:43
@caifeizhi
Copy link
Contributor

caifeizhi commented Apr 29, 2024

Thanks for your contribution @VampireAchao . And, please add new modules in .github/workflows/ci.yml and we can merge it after the new ci job passes; just like :#36

@VampireAchao
Copy link
Contributor Author

@caifeizhi Done.

@whhe
Copy link
Member

whhe commented May 7, 2024

Sorry for the late response. The basic CI workflow of this repository is based on a run.sh file in every module, so please add it in your newly added directory.

@VampireAchao
Copy link
Contributor Author

@whhe Thx for review,I've added the run.sh file in the newly created directory as advised.

@VampireAchao VampireAchao marked this pull request as draft May 9, 2024 02:06
@VampireAchao VampireAchao marked this pull request as ready for review May 9, 2024 02:13
@whhe
Copy link
Member

whhe commented May 9, 2024

Hi @VampireAchao, thank you for your update. The code is overall LGTM, but there is a little problem with the CI workflow. The current basic ci workflow already includes the step of starting a database container by default, so if you want to use testcontainers to manage the database container, you should set with_oceanbase_container to false in the ci configuration. You can check it at the readme file in repository root directory, and update it if necessary.

@VampireAchao
Copy link
Contributor Author

Thx again, PTAL 👀

Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whhe whhe merged commit 126bac1 into oceanbase:master May 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants