Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ws deque update : documentation improvement and drop functions #168

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Nov 24, 2024

Changes

  • Better documentation
  • Add drop_exn, steal_drop_exn and of_list function
  • Improve dscheck tests
  • Add examples

Note : peek functions are not as easy to add as expected.

@lyrm lyrm changed the title Ws deque update doc Ws deque update : documentation improvement and drop functions Nov 24, 2024
@lyrm lyrm force-pushed the ws_deque_update_doc branch from 9e78f1d to 2d33b55 Compare November 26, 2024 18:31
Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! A small bug (?) and some open questions regarding the documentation (but feel free to ignore, this part is subjective)

src/ws_deque.ml Outdated Show resolved Hide resolved
src/ws_deque.mli Outdated Show resolved Hide resolved
src/ws_deque.mli Outdated Show resolved Hide resolved
@lyrm lyrm merged commit 2bb4d4b into ocaml-multicore:main Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants