Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformization of Michael Scott queue with other queues #167

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

lyrm
Copy link
Collaborator

@lyrm lyrm commented Nov 24, 2024

Changes

  • Same documentation than other queues
  • Add of_list and drop_exn and tests for it
  • Add examples tested with mdx

@lyrm lyrm force-pushed the ms_queue_documentation_update branch 2 times, most recently from 6699f49 to 2e64d67 Compare November 26, 2024 18:50
Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some small typos if you have time

src/michael_scott_queue/michael_scott_queue_intf.mli Outdated Show resolved Hide resolved
src/michael_scott_queue/michael_scott_queue_intf.mli Outdated Show resolved Hide resolved
@lyrm lyrm force-pushed the ms_queue_documentation_update branch from 9d77819 to a31f971 Compare December 2, 2024 08:56
@lyrm lyrm merged commit 687680c into ocaml-multicore:main Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants