Allow to annotate pods on change using a different label #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtnpro
force-pushed
the
annotate-diff-pods-on-change
branch
from
2aa2443
to
23f3429
Compare
|
@rtnpro would you mind rebasing on |
|
@philipgough I have rebased this PR on top of latest |
This change allows users to optionally specify a different label (than the one used to watch receiver pods) for annotating pods on hashring change. This is useful in a separate Thanos receiver router and ingestor setup: https://thanos.io/tip/proposals-accepted/202012-receive-split.md/ where we need to watch a different set of ingestor pods to update the hashring, but the hashring is consumed by a different set of router pods. Signed-off-by: Ratnadeep Debnath <[email protected]>
rtnpro
force-pushed
the
annotate-diff-pods-on-change
branch
from
4e16979
to
54a6f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to optionally specify a different label (than the one used to watch receiver pods) for annotating pods on hashring change.
This is useful in a separate Thanos receiver router and ingestor setup: https://thanos.io/tip/proposals-accepted/202012-receive-split.md/ where we need to watch a different set of ingestor pods to update the hashring, but the hashring is consumed by a different set of router pods.
Fixes #125