fix: auth providers: ensure cookie secrets are len 32 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
drpebcak,
thedadams,
njhale,
StrongMonkey and
iwilltry42
cjellick
approved these changes
Jan 23, 2025
|
The real fix is here: obot-platform/obot#1427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still not sure exactly how it happened, but even though we generate 32 bytes for the cookie secret, I one time saw an auth provider crash on launch, saying it was only 31 bytes that it had. This is a little bandaid to prevent that from happening again. I saved the value that caused the problem so that I can investigate it more thoroughly in the future. For now, I just want to prevent it from happening again.