Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalisation typo in increased ccc count pattern #950

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Jun 24, 2024

As we face out the use of CARO, we need to update the corresponding patterns from CARO: cellular organism to the UBERON: multicellular organism for "whole organism" patterns.

@Clare72
Copy link
Contributor

Clare72 commented Jun 24, 2024

The CARO term is not specifically multicellular:

A general term for organism that is agnostic about single cell vs multi-cellular

Using the UBERON term would change these patterns so that they become unsuitable for unicellular organisms, so I think you need to get some unicellular organism people to sign off on this.

@sbello
Copy link

sbello commented Jun 24, 2024

@matentzn This CARO to UBERON change, restricts this pattern to multicellular organisms. Was this intended? As the patterns are all related to resistance/sensitivity of an organism to a chemical I would have thought we would want this to apply to both single cell and multicellular organisms.

@matentzn
Copy link
Collaborator Author

Which other class should I be using though? since we align all anatomy on Uberon, I need some kind of Uberon class here..

My goal here is only to get rid of the CARO class (it is the only remaining CARO dependency in uPheno which I am completely redoing now) - I am fine with whatever alternative you suggest..

@Clare72
Copy link
Contributor

Clare72 commented Jun 24, 2024

If you really need to use UBERON right now, you probably need to go up to 'anatomical structure'. Though it would be better to get a uni/multi-cellular-agnostic 'whole organism' term made. (Is there a reason UBERON doesn't have this already?)

@sbello
Copy link

sbello commented Jun 24, 2024

I agree with @Clare72 I think we should go up to http://purl.obolibrary.org/obo/UBERON_0000061 'anatomical structure' this is an ancestor of 'multicellular organism' and looking at the tree in OLS this should cover things like CL - cell and GO - cellular anatomical entity. It should cover all that we need.

@cmungall
Copy link
Member

COB?

@matentzn
Copy link
Collaborator Author

I am fine with using COB, but COB is still using the CARO class: https://www.ebi.ac.uk/ols4/ontologies/cob/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FCARO_0001010

Maybe we can remove that mapping in COB, and use the COB class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants