Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Commit

Permalink
remove bmp-js dependency (#322)
Browse files Browse the repository at this point in the history
This PR removes bmp-js and relies purely on node-canvas for image decoding.
As discussed in #319, bmp-js decodes images as ABGR, but we need RGBA.

Note: a small change to the CI setup was needed to get node-canvas installed/running on a (relatively) modern version of node.
  • Loading branch information
jkeys089 authored Nov 3, 2022
1 parent 3f3af61 commit d73961b
Show file tree
Hide file tree
Showing 9 changed files with 1,106 additions and 1,109 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ jobs:
build:
working_directory: ~/repo
docker:
- image: circleci/node:latest
- image: cimg/node:16.17.0
steps:
- checkout
- run: ./scripts/ci.sh
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@types/jest": "26.0.14",
"@types/node": "13.11.1",
"benchmark": "2.1.4",
"bmp-js": "0.1.0",
"canvas": "2.6.1",
"commitizen": "4.2.1",
"core-js": "3.6.5",
Expand Down
3 changes: 3 additions & 0 deletions scripts/ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
#
set -euo pipefail

sudo apt-get update
sudo apt-get install -y build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev

# Install dependencies
ADBLOCK=1 yarn

Expand Down
Loading

0 comments on commit d73961b

Please sign in to comment.