Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documented addresses #299

Merged
merged 5 commits into from
May 12, 2024
Merged

Update documented addresses #299

merged 5 commits into from
May 12, 2024

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Apr 2, 2024 •
edited
Loading

Description

Add Celer IM message executor.
Add Safe Singleton Factory.

TODO

  • Find out mainnet info
  • Update tokens
  • Suggest alternative section

@aefhm aefhm self-assigned this Apr 2, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name Link
🔨 Latest commit 5d2099d
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/664132f25563d40008f3e169
😎 Deploy Preview https://deploy-preview-299--oasisprotocol-sapphire-paratime.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aefhm aefhm requested a review from matevz April 2, 2024 20:37
matevz
matevz previously requested changes Apr 3, 2024
View reviewed changes
docs/addresses.md Outdated Show resolved Hide resolved
docs/addresses.md Outdated Show resolved Hide resolved
@aefhm aefhm changed the title Update addresses.md Update documented addresses Apr 15, 2024
@aefhm aefhm requested a review from matevz April 15, 2024 14:04
@aefhm
Copy link
Contributor Author

aefhm commented Apr 27, 2024 •
edited
Loading

Pulling back from history our deterministic proxy safe-global/safe-singleton-factory#78

@aefhm
Copy link
Contributor Author

aefhm commented May 12, 2024

@matevz one more look? I think changes requested are there now.

@CedarMist CedarMist self-requested a review May 12, 2024 21:25
CedarMist
CedarMist approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems correct

The 'Contract Addresses and Deployments' header does seem a bit long, but that's not a blocker.

@aefhm
Copy link
Contributor Author

aefhm commented May 12, 2024

Everything seems correct

The 'Contract Addresses and Deployments' header does seem a bit long, but that's not a blocker.

Oh yeah. Hmm, maybe we should just have 2 total sections on this page "Addresses" with two sections 1 for "Contracts" and another for the bridged tokens instead.

@CedarMist
Copy link
Member

Am happy to merge and then look at the docs from a higher-level perspective afterwards, having all the standard addresses on one page is good and easy to read.

@aefhm aefhm dismissed matevz’s stale review May 12, 2024 22:22

stale 🥺 happy to do followups

@aefhm aefhm enabled auto-merge May 12, 2024 22:23
@aefhm aefhm merged commit 5d6b79e into main May 12, 2024
16 checks passed
@aefhm aefhm deleted the aefhm-patch-1 branch May 12, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CedarMist CedarMist CedarMist approved these changes

@matevz matevz Awaiting requested review from matevz

Assignees

@aefhm aefhm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aefhm @CedarMist @matevz