Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix]: Correctly handle right click on Indicator #285

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented May 20, 2024

Pull Request Template

Description

This was really straight forward fix, just handle the right click correctly and don't propagate the event, if its handled, also don't call the super class handler, since that might to other things, that are not intentional (that was the source of the bug, since the super event handler toggles the class on clicks)

Tested locally and it now works as intended 😄

Fixes #283

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16 Totto16 linked an issue May 20, 2024 that may be closed by this pull request
@Totto16 Totto16 requested a review from oae May 20, 2024 15:59
@Totto16 Totto16 merged commit 082a835 into master May 21, 2024
1 check passed
@Totto16 Totto16 deleted the 283-bug-opening-the-content-preview-also-opens-the-contextual-menu branch May 21, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Opening the content preview also opens the contextual menu
2 participants