Bypass VM login attempt if SSO is not configured #988
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar issues: - https://access.redhat.com/solutions/6982921 - https://bugzilla.redhat.com/show_bug.cgi?id=1391146 Signed-off-by: Denis Kvist <[email protected]>
denvist
requested review from
ahadas,
bennyz,
emesika,
mwperina,
michalskrivanek,
sgratch,
smelamud and
didib
as code owners
dupondje
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Hi,
Seems like this only happens when you configured SPICE as console? Which is deprecated and gone in EL9/CentOS 9.
Next to that, as far as I see the VmLogon command seems to be triggered from invokeConsole() in SpiceConsoleModel.java.
There it only gets invoked when there is SSO configured?
Either that's not working like it should (and should get fixed), or there is an SSO configured.
This patch seems more like a hack around it than a proper solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Kvist [email protected]
Bypass VM login attempt if SSO is not configured
Similar issues:
Changes introduced with this PR
Expected behavior:
vv-console file succesful downloaded
Current behavior:
Got error while getting vv-console
Are you the owner of the code you are sending in, or do you have permission of the owner?
y