For headless VMs, DisplayType does not need to be checked. Otherwise, we will have problems while creating clones.

[denvist]

Signed-off-by: Denis Kvist [email protected]

Changes introduced with this PR

This PR fixes the following issue: an error occurs while creating clone headless VM

Steps to reproduce:

• Create VM without Display

• Create clone via Admin portal or API/SDK

Expected behavior:

The operation was successful

Current behavior:

The operation was completed with an error:

2024-09-09 16:59:26,597: Clone into VM (vm1_e759_MB_20240909_165803) started ...
2024-09-09 16:59:27,090: !!! Got unexpected exception: Fault reason is "Operation Failed". Fault detail is "[Cannot add VM. Selected display type is not supported by the operating system.]". HTTP response code is 400.

Are you the owner of the code you are sending in, or do you have permission of the owner?

y

[dupondje]

Hi,

I was trying to hit the same bug, but I'm unable to simulate it.
I create a empty VM with just Q35-UEFI and Headless Mode enabled under console.

But then I can perfectly clone the VM without errors.

Anything specific set on your side?

Next to that, I think it's also better to have it fixed in

ovirt-engine/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java

Line 83 in 89b2cd1

public boolean isGraphicsAndDisplaySupported(int osId, Version version, Collection<GraphicsType> graphics, DisplayType displayType) {

instead of there :)