Update EFS throughput mode to Elastic #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Chang <[email protected]>
cdk/jenkins_server/jenkins_server.py
Outdated
| @@ -83,7 +83,8 @@ def _create_efs(self): | |||
| file_system = efs.FileSystem(self, 'FileSystem', | |||
| vpc=self.vpc, | |||
| enable_automatic_backups=True, | |||
| encrypted=True | |||
| encrypted=True, | |||
| throughput_mode=ThroughputMode.ELASTIC | |||
There was a problem hiding this comment.
Looks like this needs to be efs.ThroughputMode.ELASTIC
Signed-off-by: Mike Chang <[email protected]>
|
The updated version of cdk supports the elastic throughput mode. I was able to successfully run the tests using the latest aws-cdk-lib (jsii also needs to be updated otherwise the update will fail). |
brianherrera
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves throughput issues due EFS disk usage IO scaling