Skip to content

Commit

Permalink
Fixes for templates (#723)
Browse files Browse the repository at this point in the history
* Fix ROSBot prefab: wheelbase and track
* Fix project.json in templates
* Bump RosRobotSample patch version

Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Co-authored-by: Kacper Dąbrowski <[email protected]>
  • Loading branch information
jhanca-robotecai and knicked committed Aug 13, 2024
1 parent 91c18b1 commit 4d23b6e
Show file tree
Hide file tree
Showing 11 changed files with 22 additions and 18 deletions.
17 changes: 9 additions & 8 deletions Gems/RosRobotSample/Assets/ROSbot.prefab
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@
"MaterialAsset": {
"assetId": {
"guid": "{D5BE771A-53A9-534E-8DCC-A91D6127540D}"
}
},
"assetHint": "robot/rosbot_xl_description/meshes/materials/antenna_plastic_-_matte_black_.azmaterial"
}
}
}
Expand Down Expand Up @@ -332,7 +333,8 @@
"MaterialAsset": {
"assetId": {
"guid": "{D5BE771A-53A9-534E-8DCC-A91D6127540D}"
}
},
"assetHint": "robot/rosbot_xl_description/meshes/materials/antenna_plastic_-_matte_black_.azmaterial"
}
}
}
Expand Down Expand Up @@ -1306,7 +1308,7 @@
"guid": "{7F445A99-8C11-5417-9D63-8BCC7DCA76C8}",
"subId": 1509562746
},
"assetHint": "robot/rosbot_xl_description/meshes/body_colision.pxmesh"
"assetHint": "robot/rosbot_xl_description/meshes/body_colision.stl.pxmesh"
},
"Configuration": {
"PhysicsAsset": {
Expand All @@ -1315,7 +1317,7 @@
"subId": 1509562746
},
"loadBehavior": "QueueLoad",
"assetHint": "robot/rosbot_xl_description/meshes/body_colision.pxmesh"
"assetHint": "robot/rosbot_xl_description/meshes/body_colision.stl.pxmesh"
},
"UseMaterialsFromAsset": false
}
Expand Down Expand Up @@ -1389,8 +1391,8 @@
"IsDrive": true
}
],
"Track": 0.17000000178813934,
"Wheelbase": 0.24799999594688416
"Track": 0.27000001072883606,
"Wheelbase": 0.3319999873638153
},
"DriveModel": {
"Limits": {
Expand Down Expand Up @@ -2032,8 +2034,7 @@
"Id": 16056351394850261418,
"Controller": {
"Configuration": {
"Field of View": 60.0,
"EditorEntityId": 15598184734561212878
"Field of View": 60.0
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion Gems/RosRobotSample/gem.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"gem_name": "RosRobotSample",
"version": "2.0.0",
"version": "2.0.1",
"display_name": "ROS Robot Sample",
"license": "Apache-2.0 or MIT",
"license_url": "https://opensource.org/licenses/Apache-2.0",
Expand Down
3 changes: 2 additions & 1 deletion Templates/Ros2FleetRobotTemplate/Template/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"StartingPointInput",
"TextureAtlas",
"WhiteBox",
"WarehouseAssets"
"WarehouseAssets",
"${Name}"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include <${Name}ModuleInterface.h>
#include "${Name}EditorSystemComponent.h"

#include "${SanitizedCppName}SampleComponent.h"
#include "${Name}SampleComponent.h"
namespace ${SanitizedCppName}
{
class ${SanitizedCppName}EditorModule
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <AzCore/Module/Module.h>

#include "${Name}SystemComponent.h"
#include "${SanitizedCppName}SampleComponent.h"
#include "${Name}SampleComponent.h"

namespace ${SanitizedCppName}
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/
// {END_LICENSE}

#include "${SanitizedCppName}SampleComponent.h"
#include "${Name}SampleComponent.h"
#include <AzCore/Component/ComponentApplicationBus.h>
#include <AzCore/Component/TransformBus.h>
#include <AzCore/Math/Transform.h>
Expand Down
3 changes: 2 additions & 1 deletion Templates/Ros2ProjectTemplate/Template/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"StartingPointInput",
"TextureAtlas",
"WhiteBox",
"WarehouseSample"
"WarehouseSample",
"${Name}"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include <AzCore/Memory/SystemAllocator.h>
#include <AzCore/Module/Module.h>

#include "${SanitizedCppName}SystemComponent.h"
#include "${Name}SystemComponent.h"

namespace ${SanitizedCppName}
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include <AzCore/Serialization/EditContext.h>
#include <AzCore/Serialization/EditContextConstants.inl>

#include "${SanitizedCppName}SystemComponent.h"
#include "${Name}SystemComponent.h"

namespace ${SanitizedCppName}
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <AzCore/Component/Component.h>

#include <${SanitizedCppName}/${SanitizedCppName}Bus.h>
#include <${Name}/${Name}Bus.h>

namespace ${SanitizedCppName}
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"Compression",
"WarehouseAssets",
"WarehouseAutomation>=2.0.0",
"ROS2>=3.1.0"
"ROS2>=3.1.0",
"${Name}"
]
}

0 comments on commit 4d23b6e

Please sign in to comment.