Update antlr to 4.13 for 33% speed up on some inputs #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivien Oddou <[email protected]>
…ne 121 NameEffor because of `fg.` Signed-off-by: Vivien Oddou <[email protected]>
…port names. Signed-off-by: Vivien Oddou <[email protected]>
Signed-off-by: Vivien Oddou <[email protected]>
Signed-off-by: Vivien Oddou <[email protected]>
…e fork and tags. Signed-off-by: Vivien Oddou <[email protected]>
….org/maven2/org/antlr/antlr4/4.13.2/ Signed-off-by: Vivien Oddou <[email protected]>
Signed-off-by: Vivien Oddou <[email protected]>
Signed-off-by: Vivien Oddou <[email protected]>
siliconvoodoo
commented
Aug 6, 2024
src/CMakeLists.txt
Outdated
Comment on lines
16
to
17
| GIT_REPOSITORY https://github.com/antlr/antlr4/ | ||
| GIT_TAG 4.13.2 |
There was a problem hiding this comment.
this is the point that would need a final commit to polish back to o3de fork.
|
Awesome. I'll take a look at o3de/antlr and add a tag for 4.13.2. |
galibzon
approved these changes
Aug 6, 2024
|
|
…ag is ready. Signed-off-by: Vivien Oddou <[email protected]>
splendid. ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion of a possible way to update antlr.
This branch could use an intervention from an o3de maintainer to go and update the o3de/antlr4 fork and put that reference in the CMakeList in a supplementary commit on top of this branch.