Add support for Specialization constants for shader options #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akio Gaule <[email protected]>
Signed-off-by: Akio Gaule <[email protected]>
Signed-off-by: Akio Gaule <[email protected]>
Signed-off-by: Akio Gaule <[email protected]>
akioCL
force-pushed
the
specialization_constants
branch
from
5468252 to
433482f
Compare
galibzon
approved these changes
Jun 11, 2024
moudgils
approved these changes
Jun 27, 2024
Signed-off-by: Akio Gaule <[email protected]>
No need for new attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command line argument ("--sc-options") was added to support shader options as specialization constants. Implementation was added for Vulkan, Metal and DX12. For Vulkan (and Metal) it translates shader options directly as specialization constants using a DXC attribute [[vk::constant_id]]. For DX12 it uses a volatile constant that will later be patched using another tool.
The [[no_specialization]] attribute was added to disable using specialization constants for a specific shader option.
Based on RFC o3de/sig-graphics-audio#163
Other relevant PRs:
o3de/DirectXShaderCompiler#4
o3de/o3de#18019