[ATOM-16433] AZSLc: Revert Matrix3x3 padding. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw Exception When Data Layout Will Encounter Alignment Differences
With DXC '-fvk-use-dx-layout'
This is v1.7.29
This is the exhaustive solution to validate the struct/class/SRG Layout data alignment problem
when:
1- There are float or float2 variables
preceded by matrices or structs that end in matrices of type:
float2x2, float3x2, float4x2
In such case the "float" or "float2" should be prepadded by a float3
variable and the solution is describbed in the error produced
by AZSLc.
2- The other cases are when "float" type variables
are preceded by matrices or structs that end in matrices of type:
float2x3, float3x3, float4x3 In such case the "float" must be prepadded by a float2 variables.
This solution is describbed in the error produced
by AZSLc.
Alternatively the user can skip this aligment error validation with
'--no-aligment-validation' command line option.
Error message example:
-------------------------------------------------------------
tests\Emission\AsError\matRC_padding.azsl(,)
: IR error #131: Detected potential alignment issues related with DXC
flag '-fvk-use-dx-layout':
- A 'float3' variable should be added before the variable 'm_f3' in
'struct /A/SD2/m_f3' at Line number 21 of
'D:\o3de-azslc\tests\Emission\AsError\matRC_padding.azsl'
- A 'float3' variable should be added before the variable 'm_f5' in
'struct /A/SD2/m_f5' at Line number 23 of
'D:\o3de-azslc\tests\Emission\AsError\matRC_padding.azsl'
-------------------------------------------------------------
Signed-off-by: garrieta <[email protected]>
galibzon
force-pushed
the
Atom/garrieta/ATOM-16433/floatRxC_alignment
branch
from
d7aecb0 to
148e0b8
Compare
santorac
approved these changes
Sep 21, 2021
jeremyong-az
approved these changes
Sep 22, 2021
galibzon
added a commit
to aws-lumberyard-dev/o3de-azslc
that referenced
this pull request
Oct 14, 2021
Throw Exception When Data Layout Will Encounter Alignment Differences
With DXC '-fvk-use-dx-layout'
This is v1.7.29
This is the exhaustive solution to validate the struct/class/SRG Layout data alignment problem
when:
1- There are float or float2 variables
preceded by matrices or structs that end in matrices of type:
float2x2, float3x2, float4x2
In such case the "float" or "float2" should be prepadded by a float3
variable and the solution is describbed in the error produced
by AZSLc.
2- The other cases are when "float" type variables
are preceded by matrices or structs that end in matrices of type:
float2x3, float3x3, float4x3 In such case the "float" must be prepadded by a float2 variables.
This solution is describbed in the error produced
by AZSLc.
Alternatively the user can skip this aligment error validation with
'--no-aligment-validation' command line option.
Error message example:
-------------------------------------------------------------
tests\Emission\AsError\matRC_padding.azsl(,)
: IR error #131: Detected potential alignment issues related with DXC
flag '-fvk-use-dx-layout'.
Alternatively you can use the option '--no-alignment-validation' to void this error and compile as is.:
- A 'float3' variable should be added before the variable 'm_f3' in
'struct /A/SD2/m_f3' at Line number 21 of
'D:\o3de-azslc\tests\Emission\AsError\matRC_padding.azsl'
- A 'float3' variable should be added before the variable 'm_f5' in
'struct /A/SD2/m_f5' at Line number 23 of
'D:\o3de-azslc\tests\Emission\AsError\matRC_padding.azsl'
-------------------------------------------------------------
Signed-off-by: garrieta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ATOM-16433] AZSLc: Revert Matrix3x3 padding.
Trigger Error When identifying alignment issues.
Provide option to bypass error.
This is v1.7.29
This is the exhaustive solution to validate the struct/class/SRG Layout data alignment problem
when:
1- There are float or float2 variables
preceded by matrices or structs that end in matrices of type:
float2x2, float3x2, float4x2
In such case the "float" or "float2" should be prepadded by a float3
variable and the solution is describbed in the error produced
by AZSLc.
2- The other cases are when "float" type variables
are preceded by matrices or structs that end in matrices of type:
float2x3, float3x3, float4x3 In such case the "float" must be prepadded by a float2 variables.
This solution is describbed in the error produced
by AZSLc.
Alternatively the user can skip this aligment error validation with
'--no-aligment-validation' command line option.
Error message example:
tests\Emission\AsError\matRC_padding.azsl(,)
: IR error #131: Detected potential alignment issues related with DXC
flag '-fvk-use-dx-layout':
'struct /A/SD2/m_f3' at Line number 21 of
'D:\o3de-azslc\tests\Emission\AsError\matRC_padding.azsl'
'struct /A/SD2/m_f5' at Line number 23 of
'D:\o3de-azslc\tests\Emission\AsError\matRC_padding.azsl'
Signed-off-by: garrieta [email protected]
[ATOM-16433] AZSLc: Revert Matrix3x3 padding.
Trigger Error When identifying alignment issues.
Provide option to bypass error.
Signed-off-by: garrieta [email protected]