Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and check against 23.10 #16

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

guillaume-haerinck
Copy link
Contributor

@guillaume-haerinck guillaume-haerinck commented Apr 27, 2024

First take on an unified readme format used accross every O3DE samples (and checked that the project still runs correctly on the release of 23.10.3)

The goal being to make the samples more accessible to the users. Both by updating the project's readme, adding a version check and linking them in O3DE showcase and doc pages. Task tracked via this issue : o3de/o3de.org#2549

Note : I wasn't able to update the gif because of git lfs, weird as I followed [those steps properly]. As there are no other .gif in the project, I uploaded it as non-lfs

Signed-off-by: guillaume-haerinck <[email protected]>
@guillaume-haerinck
Copy link
Contributor Author

Signed-off-by: guillaume-haerinck <[email protected]>
Signed-off-by: guillaume-haerinck <[email protected]>
@Ulrick28 Ulrick28 self-requested a review May 31, 2024 17:10
Copy link
Contributor

@Ulrick28 Ulrick28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved though I would like to know more about the gif and lfs issues you had.

@Ulrick28 Ulrick28 merged commit 247d113 into o3de:main Jun 3, 2024
1 check passed
@guillaume-haerinck guillaume-haerinck deleted the unified_readme branch June 7, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants