Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DXSC tool to patch specialization constant on DXIL #4

Merged
merged 4 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions include/llvm/Bitcode/BitstreamWriter.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@
#include "llvm/Support/Endian.h"
#include <vector>

// O3DE change start
#include "llvm/Bitcode/LLVMBitCodes.h"
#include <functional>
// O3DE change end

namespace llvm {

class BitstreamWriter {
Expand Down Expand Up @@ -88,6 +93,11 @@ class BitstreamWriter {
}

public:
// O3DE change start
typedef std::function<void(uint64_t, uint64_t)> ConstantHandlerFn;
ConstantHandlerFn WriteConstantCallback = nullptr;
// O3DE change end

explicit BitstreamWriter(SmallVectorImpl<char> &O)
: Out(O), CurBit(0), CurValue(0), CurCodeSize(2) {}

Expand Down Expand Up @@ -370,6 +380,22 @@ class BitstreamWriter {
WriteByte(0);
} else { // Single scalar field.
assert(RecordIdx < Vals.size() && "Invalid abbrev/record");

// O3DE Change Start
if (WriteConstantCallback &&
Vals[0] == bitc::CST_CODE_INTEGER &&
Op.getEncoding() == BitCodeAbbrevOp::VBR) {
uint64_t SCBitOffset = (uint64_t)Out.size_in_bytes() * 8 + CurBit;
uint64_t SCVal = Vals[RecordIdx];
if (Vals[RecordIdx] & 1) {
SCVal = -(SCVal >> 1);
} else {
SCVal = SCVal >> 1;
}

WriteConstantCallback(SCVal, SCBitOffset);
// O3DE Change End
akioCL marked this conversation as resolved.
Show resolved Hide resolved
}
EmitAbbreviatedField(Op, Vals[RecordIdx]);
++RecordIdx;
}
Expand Down
7 changes: 5 additions & 2 deletions include/llvm/Bitcode/ReaderWriter.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@
#include "llvm/Support/Endian.h"
#include "llvm/Support/ErrorOr.h"
#include "llvm/Support/MemoryBuffer.h"
// O3DE change start
#include "llvm/Bitcode/BitstreamWriter.h"
// O3DE change end
#include <memory>
#include <string>

namespace llvm {
class BitstreamWriter;
class DataStreamer;
class LLVMContext;
class Module;
Expand Down Expand Up @@ -69,7 +71,8 @@ namespace llvm {
/// Value in \c M. These will be reconstructed exactly when \a M is
/// deserialized.
void WriteBitcodeToFile(const Module *M, raw_ostream &Out,
bool ShouldPreserveUseListOrder = false);
bool ShouldPreserveUseListOrder = false,
BitstreamWriter::ConstantHandlerFn WriteCallback = nullptr); // O3DE change

/// isBitcodeWrapper - Return true if the given bytes are the magic bytes
/// for an LLVM IR bitcode wrapper.
Expand Down
6 changes: 5 additions & 1 deletion lib/Bitcode/Writer/BitcodeWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2494,7 +2494,8 @@ static void EmitDarwinBCHeaderAndTrailer(SmallVectorImpl<char> &Buffer,
/// WriteBitcodeToFile - Write the specified module to the specified output
/// stream.
void llvm::WriteBitcodeToFile(const Module *M, raw_ostream &Out,
bool ShouldPreserveUseListOrder) {
bool ShouldPreserveUseListOrder,
BitstreamWriter::ConstantHandlerFn WriteCallback) { // O3DE change
SmallVector<char, 0> Buffer;
Buffer.reserve(256*1024);

Expand All @@ -2507,6 +2508,9 @@ void llvm::WriteBitcodeToFile(const Module *M, raw_ostream &Out,
// Emit the module into the buffer.
{
BitstreamWriter Stream(Buffer);
// O3DE change start
Stream.WriteConstantCallback = WriteCallback;
// O3DE change end

// Emit the file header.
Stream.Emit((unsigned)'B', 8);
Expand Down
4 changes: 4 additions & 0 deletions tools/clang/tools/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,7 @@ add_subdirectory(dxlib-sample)
add_subdirectory(dotnetc)
endif (WIN32)
# HLSL Change Ends

# O3DE Change Starts
add_subdirectory(dxsc)
# O3DE Change Ends
39 changes: 39 additions & 0 deletions tools/clang/tools/dxsc/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Copyright (C) Microsoft Corporation. All rights reserved.
# This file is distributed under the University of Illinois Open Source License. See LICENSE.TXT for details.
# Builds dxsc.exe

set( LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}
DXIL
DxilContainer
DxilRootSignature
HLSL
dxcsupport
Option # option library
MSSupport # for CreateMSFileSystemForDisk
)

add_clang_executable(dxsc
dxsc.cpp
)

target_link_libraries(dxsc
dxcompiler
)

set_target_properties(dxsc PROPERTIES VERSION ${CLANG_EXECUTABLE_VERSION})

add_dependencies(dxsc dxcompiler)

if(UNIX)
set(CLANGXX_LINK_OR_COPY create_symlink)
# Create a relative symlink
set(dxsc_binary "dxsc${CMAKE_EXECUTABLE_SUFFIX}")
else()
set(CLANGXX_LINK_OR_COPY copy)
set(dxsc_binary "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${CMAKE_CFG_INTDIR}/dxsc${CMAKE_EXECUTABLE_SUFFIX}")
endif()

install(TARGETS dxsc
RUNTIME DESTINATION bin)

Loading
Loading