Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a wayland variant of Qt for Linux #266

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spham-amzn
Copy link
Contributor

  • Remove unnecessary wrapper scripts build-linux-aarch64.sh and build-linux-x86.sh
  • Add special build_config_wayland.json and Dockerfile.wayland to support the wayland variant
  • Update docker_build_qt_linux.sh to support the environment option 'ENABLE_QT_WAYLAND' which is set in the Dockerfile
  • Update docker_build_qt_linux.sh to support building the additional qtwayland package from source

- Remove unnecessary wrapper scripts build-linux-aarch64.sh and build-linux-x86.sh
- Add special build_config_wayland.json and Dockerfile.wayland to support the wayland variant
- Update docker_build_qt_linux.sh to support the environment option 'ENABLE_QT_WAYLAND' which is set in the Dockerfile
- Update docker_build_qt_linux.sh to support building the additional qtwayland package from source

Signed-off-by: Steve Pham <[email protected]>
@DrogonMar
Copy link

We could try enabling both xcb and wayland QPA plugins

@DrogonMar
Copy link

DrogonMar commented Dec 12, 2024

Why do we disable EGL in QT here?
It seems like in build due to EGL being disabled its falling back to CPU rendering with Wayland.

Sorry for duplicate message, thought I could put a message on the code instead of a comment here

@DrogonMar
Copy link

I'm not sure on how building QT works so let me know if its just because it allows it to work or not but why are you enabling wayland-server?
A Wayland server is like Windows DWM (I dont know if this is correct but Window's component that handles drawing windows to the display), KDE or Gnome.
O3DE only needs to be a Wayland client.

@spham-amzn
Copy link
Contributor Author

Why do we disable EGL in QT here? It seems like in build due to EGL being disabled its falling back to CPU rendering with Wayland.

Sorry for duplicate message, thought I could put a message on the code instead of a comment here

I don't remember, my guess is that we didn't want to build the eglfs plugin?

@DrogonMar
Copy link

I don't remember, my guess is that we didn't want to build the eglfs plugin?

Hmm, could we explicitly disable that and just allow normal EGL?
I would like to have the QT interface GPU accelerated.

@DrogonMar
Copy link

Awesome, that did work but we should disable the compositor/server part of it as thats under GPL3 which isn't good and we dont need it, look at the info here.

@@ -69,7 +69,6 @@ echo Configuring Qt ...
-no-feature-getentropy \
-no-feature-statx \
-feature-wayland-server \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the wayland server feature as its under GPLv3 and we don't need it

@DrogonMar
Copy link

DrogonMar commented Dec 18, 2024

It's still enabling the compositor feature, maybe -no-feature-wayland-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants