Update Spirv-cross package in order to address some cross compilation bugs for Mac and iOS #244
Conversation
Signed-off-by: moudgils <[email protected]>
…latest VS on the node to build the package Signed-off-by: moudgils <[email protected]>
Signed-off-by: moudgils <[email protected]>
| "cmake_generate_args_debug":[ | ||
| "-G", | ||
| "\"Visual Studio 16 2019\"", | ||
| "-A", | ||
| "x64", | ||
| "-T", | ||
| "host=x64", | ||
| "-DSPIRV_CROSS_CLI=ON", | ||
| "-DSPIRV_CROSS_SHARED=OFF", | ||
| "-DCMAKE_INSTALL_LIBDIR=\"lib/Debug\"", | ||
| "-DCMAKE_INSTALL_BINDIR=\"bin/Debug\"", | ||
| "-DCMAKE_BUILD_TYPE=Debug" | ||
| ], |
There was a problem hiding this comment.
Why was the entire cmake_generate_args_debug removed? Its causing the pull_and_build_from_git script to fail. You should only need to remove the -G, -A, -T, and host=x64 arguments
There was a problem hiding this comment.
If the intention is to only build on the release target, then a --build_configs release argument should be added to each package_build_list_host_*.jsoncommand.
pull_and_build_from_git.py defaults to the release and debug target if no argument is given: https://github.com/o3de/3p-package-source/blob/main/Scripts/extras/pull_and_build_from_git.py#L279C11-L279C103
There was a problem hiding this comment.
I brought the debug configs back to allow the packages to be built.
…ripts Signed-off-by: moudgils <[email protected]>
Signed-off-by: moudgils <[email protected]>
|
This is the autogenerated PR for runtime - o3de/o3de#17446. Will merge both PRs together |
The current version of SPIRV-Cross is throwing exceptions when trying to compile spirv into metalSL which is addressed by the latest version.