Adding safeguards for NPEs and certain conditions #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
reviewed
Dec 9, 2024
| @@ -18,4 +18,4 @@ echo "Creating judgments index..." | |||
| # }' | |||
|
|
|||
| echo "Creating judgments..." | |||
| curl -s -X POST "http://localhost:9200/_plugins/search_quality_eval/judgments?click_model=coec&max_rank=1" | |||
| curl -s -X POST "http://localhost:9200/_plugins/search_quality_eval/judgments?click_model=coec&max_rank=20" | |||
There was a problem hiding this comment.
so this is to go a lot deeper....?
There was a problem hiding this comment.
Yes, 20 was the original. 1 was for testing.
epugh
reviewed
Dec 9, 2024
| @@ -324,6 +330,7 @@ public Map<Integer, Double> getRankAggregatedClickThrough() throws Exception { | |||
| final Collection<? extends Terms.Bucket> positionBuckets = positionTerms.getBuckets(); | |||
|
|
|||
| for(final Terms.Bucket positionBucket : positionBuckets) { | |||
| LOGGER.info("Inserting client event from position {} with click count {}", positionBucket.getKey(), (double) positionBucket.getDocCount()); | |||
epugh
reviewed
Dec 9, 2024
| if(!(impressionCounts.get(x) == null)) { | ||
|
|
||
| // Calculate the CTR by dividing the number of clicks by the number of impressions. | ||
| LOGGER.info("Position = {}, Click Count = {}, Event Count = {}", x, clickCounts.get(x), impressionCounts.get(x)); |
There was a problem hiding this comment.
just wondering if these .info are really .debug?
There was a problem hiding this comment.
Yes, they are. Probably could use a good going-over to make sure level are appropriate.
epugh
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.