Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be aggressive about checking state consistency #842

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Be aggressive about checking state consistency #842

merged 1 commit into from
Apr 4, 2024

Conversation

mrmr1993
Copy link
Member

This PR adds IDs to the snarky run state, and uses them to check that the state wasn't clobbered by some concurrent circuit execution.

mitschabaude
mitschabaude approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very important change, only downside is that the failwiths don't seem to play nicely with alcotest (although that feels more like an alcotest problem to me)

@mitschabaude mitschabaude merged commit f95539e into master Apr 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @mitschabaude