Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to reduce confusing terms #90

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gambon2010
Copy link
Contributor

The goal of the pull request is to refactor the TrajectoryData class to reduce confusing terms so:
distance >> x
height >> y
look_distance >> distance
drop_adj >> drop_angle
windage_adj >> windage_angle

I've run the integrated unit tests and everything seems to pass, but feel free to check the code on your end as I might have missed something

@o-murphy
Copy link
Owner

wouldn't be merged yet, cause of broken API backwards compatibility, and also tests fully failed

@o-murphy
Copy link
Owner

@gambon2010 please run pytest locally to verify u're not broke the code

pytest ./tests

@gambon2010
Copy link
Contributor Author

@gambon2010 please run pytest locally to verify u're not broke the code

pytest ./tests

Hi! I've run them locally and for whatever reason they work on my machine. I'll try to fix the issue in the next few days, haven't had time to dig into it.

@o-murphy
Copy link
Owner

@gambon2010 please run pytest locally to verify u're not broke the code

pytest ./tests

Hi! I've run them locally and for whatever reason they work on my machine. I'll try to fix the issue in the next few days, haven't had time to dig into it.

Also we can't refactor Trajectory Data now, because of its backward compatibility would be broken

@o-murphy o-murphy linked an issue Sep 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring to reduce confusing terms
2 participants