Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper constructors to some builders #531

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

abitofevrything
Copy link
Member

Description

Some builders have fields that are only available under certain circumstances (often, when a specific other argument is specified). This PR adds constructors that clarify which fields are available where.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything abitofevrything added the enhancement New feature or request label Aug 27, 2023
@abitofevrything abitofevrything added this to the 6.0 milestone Aug 27, 2023
@abitofevrything abitofevrything self-assigned this Aug 27, 2023
@abitofevrything abitofevrything merged commit d5fd47d into rewrite Aug 27, 2023
7 checks passed
@abitofevrything abitofevrything deleted the feat/better-builders branch August 27, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants