Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache clearing #518

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Improve cache clearing #518

merged 2 commits into from
Aug 19, 2023

Conversation

abitofevrything
Copy link
Member

Description

Rewrites the caching code to not hold on to outdated objects and empty caches.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything abitofevrything added bug Something isn't working enhancement New feature or request labels Aug 19, 2023
@abitofevrything abitofevrything added this to the 6.0 milestone Aug 19, 2023
@abitofevrything abitofevrything self-assigned this Aug 19, 2023
@abitofevrything abitofevrything merged commit 0e96354 into rewrite Aug 19, 2023
7 checks passed
@abitofevrything abitofevrything deleted the bug/cache-clearing branch August 19, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants